From 0ba973a96681d5c5f85423176d63c14f8cbc1c25 Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Thu, 9 Feb 2023 01:25:33 +0000 Subject: [PATCH 367/394] telemetry: fix repeat display when callback don't init dict [ upstream commit ff50c4f9136781bae9089c596e0a12d113e1d474 ] When a telemetry callback doesn't initialize the telemetry data structure and returns a non-negative number, the telemetry will repeat to display the last result. This patch zero the data structure to avoid the problem. Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality") Cc: stable@dpdk.org Signed-off-by: Chengwen Feng Reviewed-by: Bruce Richardson --- lib/telemetry/telemetry.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c index 52048de55c..2c12db20cb 100644 --- a/lib/telemetry/telemetry.c +++ b/lib/telemetry/telemetry.c @@ -332,7 +332,7 @@ output_json(const char *cmd, const struct rte_tel_data *d, int s) static void perform_command(telemetry_cb fn, const char *cmd, const char *param, int s) { - struct rte_tel_data data; + struct rte_tel_data data = {0}; int ret = fn(cmd, param, &data); if (ret < 0) { -- 2.23.0