Sync some patchs from upstreaming and modifies are as follow: - maintainers: update for hns3 driver - app/testpmd: add command to flush multicast MAC addresses - app/testpmd: fix help string - app/testpmd: fix multicast address pool leak - net/hns3: optimize SVE Rx performance - net/hns3: optimize rearm mbuf for SVE Rx - net/hns3: optimize free mbuf for SVE Tx - net/hns3: fix order in NEON Rx - net/hns3: fix traffic management dump text alignment - net/hns3: fix traffic management thread safety - net/hns3: fix flushing multicast MAC address - net/hns3: fix error code for multicast resource - net/hns3: fix VF default MAC modified when set failed - net/hns3: fix index to look up table in NEON Rx - net/hns3: fix non-zero weight for disabled TC - config/arm: add HiSilicon HIP10 Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
224 lines
7.5 KiB
Diff
224 lines
7.5 KiB
Diff
From 133dbfed220120724a60a2b7deae5ec7d4c38301 Mon Sep 17 00:00:00 2001
|
|
From: Huisong Li <lihuisong@huawei.com>
|
|
Date: Tue, 11 Jul 2023 18:24:47 +0800
|
|
Subject: [PATCH 361/366] net/hns3: optimize rearm mbuf for SVE Rx
|
|
|
|
[ upstream commit d49b64477f246e53210488825fdd92ccf53fa184 ]
|
|
|
|
Use hns3_rxq_rearm_mbuf() to replace the hns3_rxq_rearm_mbuf_sve()
|
|
to optimize the performance of SVE Rx.
|
|
|
|
On the rxonly forwarding mode, the performance of a single queue
|
|
for 64B packet is improved by ~15%.
|
|
|
|
Signed-off-by: Huisong Li <lihuisong@huawei.com>
|
|
Signed-off-by: Dongdong Liu <liudongdong3@huawei.com>
|
|
---
|
|
drivers/net/hns3/hns3_rxtx_vec.c | 51 ---------------------------
|
|
drivers/net/hns3/hns3_rxtx_vec.h | 51 +++++++++++++++++++++++++++
|
|
drivers/net/hns3/hns3_rxtx_vec_sve.c | 52 ++--------------------------
|
|
3 files changed, 53 insertions(+), 101 deletions(-)
|
|
|
|
diff --git a/drivers/net/hns3/hns3_rxtx_vec.c b/drivers/net/hns3/hns3_rxtx_vec.c
|
|
index 153866c..5cdfa60 100644
|
|
--- a/drivers/net/hns3/hns3_rxtx_vec.c
|
|
+++ b/drivers/net/hns3/hns3_rxtx_vec.c
|
|
@@ -55,57 +55,6 @@ hns3_xmit_pkts_vec(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
|
|
return nb_tx;
|
|
}
|
|
|
|
-static inline void
|
|
-hns3_rxq_rearm_mbuf(struct hns3_rx_queue *rxq)
|
|
-{
|
|
-#define REARM_LOOP_STEP_NUM 4
|
|
- struct hns3_entry *rxep = &rxq->sw_ring[rxq->rx_rearm_start];
|
|
- struct hns3_desc *rxdp = rxq->rx_ring + rxq->rx_rearm_start;
|
|
- uint64_t dma_addr;
|
|
- int i;
|
|
-
|
|
- if (unlikely(rte_mempool_get_bulk(rxq->mb_pool, (void *)rxep,
|
|
- HNS3_DEFAULT_RXQ_REARM_THRESH) < 0)) {
|
|
- rte_eth_devices[rxq->port_id].data->rx_mbuf_alloc_failed++;
|
|
- return;
|
|
- }
|
|
-
|
|
- for (i = 0; i < HNS3_DEFAULT_RXQ_REARM_THRESH; i += REARM_LOOP_STEP_NUM,
|
|
- rxep += REARM_LOOP_STEP_NUM, rxdp += REARM_LOOP_STEP_NUM) {
|
|
- if (likely(i <
|
|
- HNS3_DEFAULT_RXQ_REARM_THRESH - REARM_LOOP_STEP_NUM)) {
|
|
- rte_prefetch_non_temporal(rxep[4].mbuf);
|
|
- rte_prefetch_non_temporal(rxep[5].mbuf);
|
|
- rte_prefetch_non_temporal(rxep[6].mbuf);
|
|
- rte_prefetch_non_temporal(rxep[7].mbuf);
|
|
- }
|
|
-
|
|
- dma_addr = rte_mbuf_data_iova_default(rxep[0].mbuf);
|
|
- rxdp[0].addr = rte_cpu_to_le_64(dma_addr);
|
|
- rxdp[0].rx.bd_base_info = 0;
|
|
-
|
|
- dma_addr = rte_mbuf_data_iova_default(rxep[1].mbuf);
|
|
- rxdp[1].addr = rte_cpu_to_le_64(dma_addr);
|
|
- rxdp[1].rx.bd_base_info = 0;
|
|
-
|
|
- dma_addr = rte_mbuf_data_iova_default(rxep[2].mbuf);
|
|
- rxdp[2].addr = rte_cpu_to_le_64(dma_addr);
|
|
- rxdp[2].rx.bd_base_info = 0;
|
|
-
|
|
- dma_addr = rte_mbuf_data_iova_default(rxep[3].mbuf);
|
|
- rxdp[3].addr = rte_cpu_to_le_64(dma_addr);
|
|
- rxdp[3].rx.bd_base_info = 0;
|
|
- }
|
|
-
|
|
- rxq->rx_rearm_start += HNS3_DEFAULT_RXQ_REARM_THRESH;
|
|
- if (rxq->rx_rearm_start >= rxq->nb_rx_desc)
|
|
- rxq->rx_rearm_start = 0;
|
|
-
|
|
- rxq->rx_rearm_nb -= HNS3_DEFAULT_RXQ_REARM_THRESH;
|
|
-
|
|
- hns3_write_reg_opt(rxq->io_head_reg, HNS3_DEFAULT_RXQ_REARM_THRESH);
|
|
-}
|
|
-
|
|
uint16_t
|
|
hns3_recv_pkts_vec(void *__restrict rx_queue,
|
|
struct rte_mbuf **__restrict rx_pkts,
|
|
diff --git a/drivers/net/hns3/hns3_rxtx_vec.h b/drivers/net/hns3/hns3_rxtx_vec.h
|
|
index 2c8a919..a9a6774 100644
|
|
--- a/drivers/net/hns3/hns3_rxtx_vec.h
|
|
+++ b/drivers/net/hns3/hns3_rxtx_vec.h
|
|
@@ -94,4 +94,55 @@ hns3_rx_reassemble_pkts(struct rte_mbuf **rx_pkts,
|
|
|
|
return count;
|
|
}
|
|
+
|
|
+static inline void
|
|
+hns3_rxq_rearm_mbuf(struct hns3_rx_queue *rxq)
|
|
+{
|
|
+#define REARM_LOOP_STEP_NUM 4
|
|
+ struct hns3_entry *rxep = &rxq->sw_ring[rxq->rx_rearm_start];
|
|
+ struct hns3_desc *rxdp = rxq->rx_ring + rxq->rx_rearm_start;
|
|
+ uint64_t dma_addr;
|
|
+ int i;
|
|
+
|
|
+ if (unlikely(rte_mempool_get_bulk(rxq->mb_pool, (void *)rxep,
|
|
+ HNS3_DEFAULT_RXQ_REARM_THRESH) < 0)) {
|
|
+ rte_eth_devices[rxq->port_id].data->rx_mbuf_alloc_failed++;
|
|
+ return;
|
|
+ }
|
|
+
|
|
+ for (i = 0; i < HNS3_DEFAULT_RXQ_REARM_THRESH; i += REARM_LOOP_STEP_NUM,
|
|
+ rxep += REARM_LOOP_STEP_NUM, rxdp += REARM_LOOP_STEP_NUM) {
|
|
+ if (likely(i <
|
|
+ HNS3_DEFAULT_RXQ_REARM_THRESH - REARM_LOOP_STEP_NUM)) {
|
|
+ rte_prefetch_non_temporal(rxep[4].mbuf);
|
|
+ rte_prefetch_non_temporal(rxep[5].mbuf);
|
|
+ rte_prefetch_non_temporal(rxep[6].mbuf);
|
|
+ rte_prefetch_non_temporal(rxep[7].mbuf);
|
|
+ }
|
|
+
|
|
+ dma_addr = rte_mbuf_data_iova_default(rxep[0].mbuf);
|
|
+ rxdp[0].addr = rte_cpu_to_le_64(dma_addr);
|
|
+ rxdp[0].rx.bd_base_info = 0;
|
|
+
|
|
+ dma_addr = rte_mbuf_data_iova_default(rxep[1].mbuf);
|
|
+ rxdp[1].addr = rte_cpu_to_le_64(dma_addr);
|
|
+ rxdp[1].rx.bd_base_info = 0;
|
|
+
|
|
+ dma_addr = rte_mbuf_data_iova_default(rxep[2].mbuf);
|
|
+ rxdp[2].addr = rte_cpu_to_le_64(dma_addr);
|
|
+ rxdp[2].rx.bd_base_info = 0;
|
|
+
|
|
+ dma_addr = rte_mbuf_data_iova_default(rxep[3].mbuf);
|
|
+ rxdp[3].addr = rte_cpu_to_le_64(dma_addr);
|
|
+ rxdp[3].rx.bd_base_info = 0;
|
|
+ }
|
|
+
|
|
+ rxq->rx_rearm_start += HNS3_DEFAULT_RXQ_REARM_THRESH;
|
|
+ if (rxq->rx_rearm_start >= rxq->nb_rx_desc)
|
|
+ rxq->rx_rearm_start = 0;
|
|
+
|
|
+ rxq->rx_rearm_nb -= HNS3_DEFAULT_RXQ_REARM_THRESH;
|
|
+
|
|
+ hns3_write_reg_opt(rxq->io_head_reg, HNS3_DEFAULT_RXQ_REARM_THRESH);
|
|
+}
|
|
#endif /* HNS3_RXTX_VEC_H */
|
|
diff --git a/drivers/net/hns3/hns3_rxtx_vec_sve.c b/drivers/net/hns3/hns3_rxtx_vec_sve.c
|
|
index 51d4bf3..1251939 100644
|
|
--- a/drivers/net/hns3/hns3_rxtx_vec_sve.c
|
|
+++ b/drivers/net/hns3/hns3_rxtx_vec_sve.c
|
|
@@ -237,54 +237,6 @@ hns3_recv_burst_vec_sve(struct hns3_rx_queue *__restrict rxq,
|
|
return nb_rx;
|
|
}
|
|
|
|
-static inline void
|
|
-hns3_rxq_rearm_mbuf_sve(struct hns3_rx_queue *rxq)
|
|
-{
|
|
-#define REARM_LOOP_STEP_NUM 4
|
|
- struct hns3_entry *rxep = &rxq->sw_ring[rxq->rx_rearm_start];
|
|
- struct hns3_desc *rxdp = rxq->rx_ring + rxq->rx_rearm_start;
|
|
- struct hns3_entry *rxep_tmp = rxep;
|
|
- int i;
|
|
-
|
|
- if (unlikely(rte_mempool_get_bulk(rxq->mb_pool, (void *)rxep,
|
|
- HNS3_DEFAULT_RXQ_REARM_THRESH) < 0)) {
|
|
- rte_eth_devices[rxq->port_id].data->rx_mbuf_alloc_failed++;
|
|
- return;
|
|
- }
|
|
-
|
|
- for (i = 0; i < HNS3_DEFAULT_RXQ_REARM_THRESH; i += REARM_LOOP_STEP_NUM,
|
|
- rxep_tmp += REARM_LOOP_STEP_NUM) {
|
|
- svuint64_t prf = svld1_u64(PG64_256BIT, (uint64_t *)rxep_tmp);
|
|
- svprfd_gather_u64base(PG64_256BIT, prf, SV_PLDL1STRM);
|
|
- }
|
|
-
|
|
- for (i = 0; i < HNS3_DEFAULT_RXQ_REARM_THRESH; i += REARM_LOOP_STEP_NUM,
|
|
- rxep += REARM_LOOP_STEP_NUM, rxdp += REARM_LOOP_STEP_NUM) {
|
|
- uint64_t iova[REARM_LOOP_STEP_NUM];
|
|
- iova[0] = rxep[0].mbuf->buf_iova;
|
|
- iova[1] = rxep[1].mbuf->buf_iova;
|
|
- iova[2] = rxep[2].mbuf->buf_iova;
|
|
- iova[3] = rxep[3].mbuf->buf_iova;
|
|
- svuint64_t siova = svld1_u64(PG64_256BIT, iova);
|
|
- siova = svadd_n_u64_z(PG64_256BIT, siova, RTE_PKTMBUF_HEADROOM);
|
|
- svuint64_t ol_base = svdup_n_u64(0);
|
|
- svst1_scatter_u64offset_u64(PG64_256BIT,
|
|
- (uint64_t *)&rxdp[0].addr,
|
|
- svindex_u64(BD_FIELD_ADDR_OFFSET, BD_SIZE), siova);
|
|
- svst1_scatter_u64offset_u64(PG64_256BIT,
|
|
- (uint64_t *)&rxdp[0].addr,
|
|
- svindex_u64(BD_FIELD_OL_OFFSET, BD_SIZE), ol_base);
|
|
- }
|
|
-
|
|
- rxq->rx_rearm_start += HNS3_DEFAULT_RXQ_REARM_THRESH;
|
|
- if (rxq->rx_rearm_start >= rxq->nb_rx_desc)
|
|
- rxq->rx_rearm_start = 0;
|
|
-
|
|
- rxq->rx_rearm_nb -= HNS3_DEFAULT_RXQ_REARM_THRESH;
|
|
-
|
|
- hns3_write_reg_opt(rxq->io_head_reg, HNS3_DEFAULT_RXQ_REARM_THRESH);
|
|
-}
|
|
-
|
|
uint16_t
|
|
hns3_recv_pkts_vec_sve(void *__restrict rx_queue,
|
|
struct rte_mbuf **__restrict rx_pkts,
|
|
@@ -300,7 +252,7 @@ hns3_recv_pkts_vec_sve(void *__restrict rx_queue,
|
|
nb_pkts = RTE_ALIGN_FLOOR(nb_pkts, HNS3_SVE_DEFAULT_DESCS_PER_LOOP);
|
|
|
|
if (rxq->rx_rearm_nb > HNS3_DEFAULT_RXQ_REARM_THRESH)
|
|
- hns3_rxq_rearm_mbuf_sve(rxq);
|
|
+ hns3_rxq_rearm_mbuf(rxq);
|
|
|
|
if (unlikely(!(rxdp->rx.bd_base_info &
|
|
rte_cpu_to_le_32(1u << HNS3_RXD_VLD_B))))
|
|
@@ -331,7 +283,7 @@ hns3_recv_pkts_vec_sve(void *__restrict rx_queue,
|
|
break;
|
|
|
|
if (rxq->rx_rearm_nb > HNS3_DEFAULT_RXQ_REARM_THRESH)
|
|
- hns3_rxq_rearm_mbuf_sve(rxq);
|
|
+ hns3_rxq_rearm_mbuf(rxq);
|
|
}
|
|
|
|
return nb_rx;
|
|
--
|
|
2.41.0.windows.2
|
|
|