7d8194517a
Sync some patches for hns3 PMD, telemetry and testpmd. And main modifications are as follows: - backport some bugfixes for hns3 - revert Tx performance optimization for hns3 - add Rx/Tx descriptor dump feature for hns3 - refactor some RSS commands for testpmd - add ethdev telemetry private dump - add dmadev telemetry - sync telemetry lib Signed-off-by: Huisong Li <lihuisong@huawei.com> (cherry picked from commit 4f06d27eff9aa99c2e2073ac74328893990ed8ed)
53 lines
1.8 KiB
Diff
53 lines
1.8 KiB
Diff
From 2674bf9f28b9dd7724d72096a8e54b19400239bd Mon Sep 17 00:00:00 2001
|
|
From: Bruce Richardson <bruce.richardson@intel.com>
|
|
Date: Fri, 21 Oct 2022 15:37:05 +0800
|
|
Subject: [PATCH 189/189] telemetry: make help command more helpful
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
The /help telemetry command prints out the help text for the given
|
|
command passed in as parameter. However, entering /help without any
|
|
parameters does not give any useful information as to the fact that you
|
|
need to pass in a command to get help on. Update the command so it
|
|
prints its own help text when called without any parameters.
|
|
|
|
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
|
|
Acked-by: Ciara Power <ciara.power@intel.com>
|
|
Acked-by: Morten Brørup <mb@smartsharesystems.com>
|
|
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
|
|
---
|
|
lib/telemetry/telemetry.c | 12 +++++++-----
|
|
1 file changed, 7 insertions(+), 5 deletions(-)
|
|
|
|
diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c
|
|
index 25ab6ed877..52048de55c 100644
|
|
--- a/lib/telemetry/telemetry.c
|
|
+++ b/lib/telemetry/telemetry.c
|
|
@@ -141,15 +141,17 @@ command_help(const char *cmd __rte_unused, const char *params,
|
|
struct rte_tel_data *d)
|
|
{
|
|
int i;
|
|
+ /* if no parameters return our own help text */
|
|
+ const char *to_lookup = (params == NULL ? cmd : params);
|
|
|
|
- if (!params)
|
|
- return -1;
|
|
rte_tel_data_start_dict(d);
|
|
rte_spinlock_lock(&callback_sl);
|
|
for (i = 0; i < num_callbacks; i++)
|
|
- if (strcmp(params, callbacks[i].cmd) == 0) {
|
|
- rte_tel_data_add_dict_string(d, params,
|
|
- callbacks[i].help);
|
|
+ if (strcmp(to_lookup, callbacks[i].cmd) == 0) {
|
|
+ if (params == NULL)
|
|
+ rte_tel_data_string(d, callbacks[i].help);
|
|
+ else
|
|
+ rte_tel_data_add_dict_string(d, params, callbacks[i].help);
|
|
break;
|
|
}
|
|
rte_spinlock_unlock(&callback_sl);
|
|
--
|
|
2.23.0
|
|
|