From 587b40380b20f0e0e84a022155954c8530246463 Mon Sep 17 00:00:00 2001
From: lwg <liweiganga@uniontech.com>
Date: Wed, 6 Dec 2023 09:47:21 +0800
Subject: [PATCH] fix CVE-2023-49284

---
 backport-CVE-2023-49284.patch | 52 +++++++++++++++++++++++++++++++++++
 fish.spec                     |  7 ++++-
 2 files changed, 58 insertions(+), 1 deletion(-)
 create mode 100644 backport-CVE-2023-49284.patch

diff --git a/backport-CVE-2023-49284.patch b/backport-CVE-2023-49284.patch
new file mode 100644
index 0000000..8f42c47
--- /dev/null
+++ b/backport-CVE-2023-49284.patch
@@ -0,0 +1,52 @@
+From 09986f5563e31e2c900a606438f1d60d008f3a14 Mon Sep 17 00:00:00 2001
+From: Fabian Boehm <FHomborg@gmail.com>
+Date: Sat, 2 Dec 2023 11:06:07 +0100
+Subject: [PATCH] Encode all ENCODE_DIRECT codepoints with encode_direct
+
+---
+ src/common.cpp          |  7 ++++---
+ tests/checks/basic.fish | 11 ++++++++++-
+ 2 files changed, 14 insertions(+), 4 deletions(-)
+
+diff --git a/src/common.cpp b/src/common.cpp
+index c419bc1..bda5fe6 100644
+--- a/src/common.cpp
++++ b/src/common.cpp
+@@ -355,9 +355,7 @@ static wcstring str2wcs_internal(const char *in, const size_t in_len) {
+         } else {
+             ret = std::mbrtowc(&wc, &in[in_pos], in_len - in_pos, &state);
+             // Determine whether to encode this character with our crazy scheme.
+-            if (wc >= ENCODE_DIRECT_BASE && wc < ENCODE_DIRECT_BASE + 256) {
+-                use_encode_direct = true;
+-            } else if (wc == INTERNAL_SEPARATOR) {
++            if (fish_reserved_codepoint(wc)) {
+                 use_encode_direct = true;
+             } else if (ret == static_cast<size_t>(-2)) {
+                 // Incomplete sequence.
+@@ -1317,6 +1315,9 @@ maybe_t<size_t> read_unquoted_escape(const wchar_t *input, wcstring *result, boo
+     }
+ 
+     if (!errored && result_char_or_none.has_value()) {
++        if (fish_reserved_codepoint(*result_char_or_none)) {
++            return none();
++        }
+         result->push_back(*result_char_or_none);
+     }
+     if (errored) return none();
+diff --git a/tests/checks/basic.fish b/tests/checks/basic.fish
+index c9a2d58..83bee8f 100644
+--- a/tests/checks/basic.fish
++++ b/tests/checks/basic.fish
+@@ -500,3 +500,12 @@ echo banana
+ # This used to be a parse error - #7685.
+ echo (echo hello\\)
+ # CHECK: hello\
++
++$fish -c 'echo \ufdd2"fart"'
++# CHECKRR: fish: Invalid token '\ufdd2"fart"'
++# CHECKRR: echo \ufdd2"fart"
++# CHECHRR: ^~~~~~~~~~~^
++
++echo (sh -c 'printf $\'\ufdd2foo\'') | string escape
++# CHECK: \Xef\Xbf\X92foo
++
diff --git a/fish.spec b/fish.spec
index 8abd2b4..802a9f4 100644
--- a/fish.spec
+++ b/fish.spec
@@ -1,6 +1,6 @@
 Name:           fish
 Version:        3.3.1
-Release:        4
+Release:        5
 Summary:        Friendly interactive shell
 License:        GPLv2 and BSD and ISC and LGPLv2+ and MIT
 URL:            https://fishshell.com
@@ -9,6 +9,8 @@ Source0:        https://github.com/fish-shell/fish-shell/releases/download/%{ver
 Patch01:        fix-test-failure.patch
 # https://github.com/fish-shell/fish-shell/commit/37625053d424c1ab88de2b0c50c7fe71e1468e2c
 Patch02:        CVE-2022-20001.patch
+# https://github.com/fish-shell/fish-shell/commit/09986f5563e31e2c900a606438f1d60d008f3a14
+#Patch03:        backport-CVE-2023-49284.patch
 
 BuildRequires:  cmake >= 3.2
 BuildRequires:  ninja-build
@@ -101,6 +103,9 @@ fi
 %{_datadir}/pixmaps/fish.png
 
 %changelog
+* Wed Dec 06 2023 lwg <relpeace@yeah.net> - 3.3.1-5
+- fix CVE-2023-49284
+
 * Mon Dec 12 2022 yaoxin <yaoxin30@h-partners.com> - 3.3.1-4
 - Synchronize the release of 22.03-LTS