[SPR] Add attribute hot judgement for INLINE_HINT_known_hot hint.
We set up INLINE_HINT_known_hot hint only when we have profile feedback, now add function attribute judgement for it, when both caller and callee have __attribute__((hot)), we will also set up INLINE_HINT_known_hot hint for it. With this patch applied, ADL Multi-copy: 538.imagic_r 16.7% ICX Multi-copy: 538.imagic_r 15.2% CLX Multi-copy: 538.imagic_r 12.7% Znver3 Multi-copy: 538.imagic_r 10.6% Arm Multi-copy: 538.imagic_r 13.4% gcc/ChangeLog * ipa-inline-analysis.cc (do_estimate_edge_time): Add function attribute judgement for INLINE_HINT_known_hot hint. gcc/testsuite/ChangeLog: * gcc.dg/ipa/inlinehint-6.c: New test. url:https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=1b9a5cc9ec08e9f239dd2096edcc447b7a72f64a
This commit is contained in:
Cui,Lili
Hu, Lin1
parent
db41342444
commit
4dc52e5c19
123
0004-Add-attribute-hot-judgement-for-INLINE_HINT_known_ho.patch
Normal file
123
0004-Add-attribute-hot-judgement-for-INLINE_HINT_known_ho.patch
Normal file
@ -0,0 +1,123 @@
|
||||
From 1b9a5cc9ec08e9f239dd2096edcc447b7a72f64a Mon Sep 17 00:00:00 2001
|
||||
From: "Cui,Lili" <lili.cui@intel.com>
|
||||
Date: Tue, 1 Nov 2022 09:16:49 +0800
|
||||
Subject: [PATCH] Add attribute hot judgement for INLINE_HINT_known_hot hint.
|
||||
|
||||
We set up INLINE_HINT_known_hot hint only when we have profile feedback,
|
||||
now add function attribute judgement for it, when both caller and callee
|
||||
have __attribute__((hot)), we will also set up INLINE_HINT_known_hot hint
|
||||
for it.
|
||||
|
||||
With this patch applied,
|
||||
ADL Multi-copy: 538.imagic_r 16.7%
|
||||
ICX Multi-copy: 538.imagic_r 15.2%
|
||||
CLX Multi-copy: 538.imagic_r 12.7%
|
||||
Znver3 Multi-copy: 538.imagic_r 10.6%
|
||||
Arm Multi-copy: 538.imagic_r 13.4%
|
||||
|
||||
gcc/ChangeLog
|
||||
|
||||
* ipa-inline-analysis.cc (do_estimate_edge_time): Add function attribute
|
||||
judgement for INLINE_HINT_known_hot hint.
|
||||
|
||||
gcc/testsuite/ChangeLog:
|
||||
|
||||
* gcc.dg/ipa/inlinehint-6.c: New test.
|
||||
---
|
||||
gcc/ipa-inline-analysis.cc | 13 ++++---
|
||||
gcc/testsuite/gcc.dg/ipa/inlinehint-6.c | 47 +++++++++++++++++++++++++
|
||||
2 files changed, 56 insertions(+), 4 deletions(-)
|
||||
create mode 100644 gcc/testsuite/gcc.dg/ipa/inlinehint-6.c
|
||||
|
||||
diff --git a/gcc/ipa-inline-analysis.cc b/gcc/ipa-inline-analysis.cc
|
||||
index 1ca685d1b0e..7bd29c36590 100644
|
||||
--- a/gcc/ipa-inline-analysis.cc
|
||||
+++ b/gcc/ipa-inline-analysis.cc
|
||||
@@ -48,6 +48,7 @@ along with GCC; see the file COPYING3. If not see
|
||||
#include "ipa-utils.h"
|
||||
#include "cfgexpand.h"
|
||||
#include "gimplify.h"
|
||||
+#include "attribs.h"
|
||||
|
||||
/* Cached node/edge growths. */
|
||||
fast_call_summary<edge_growth_cache_entry *, va_heap> *edge_growth_cache = NULL;
|
||||
@@ -249,15 +250,19 @@ do_estimate_edge_time (struct cgraph_edge *edge, sreal *ret_nonspec_time)
|
||||
hints = estimates.hints;
|
||||
}
|
||||
|
||||
- /* When we have profile feedback, we can quite safely identify hot
|
||||
- edges and for those we disable size limits. Don't do that when
|
||||
- probability that caller will call the callee is low however, since it
|
||||
+ /* When we have profile feedback or function attribute, we can quite safely
|
||||
+ identify hot edges and for those we disable size limits. Don't do that
|
||||
+ when probability that caller will call the callee is low however, since it
|
||||
may hurt optimization of the caller's hot path. */
|
||||
- if (edge->count.ipa ().initialized_p () && edge->maybe_hot_p ()
|
||||
+ if ((edge->count.ipa ().initialized_p () && edge->maybe_hot_p ()
|
||||
&& (edge->count.ipa ().apply_scale (2, 1)
|
||||
> (edge->caller->inlined_to
|
||||
? edge->caller->inlined_to->count.ipa ()
|
||||
: edge->caller->count.ipa ())))
|
||||
+ || (lookup_attribute ("hot", DECL_ATTRIBUTES (edge->caller->decl))
|
||||
+ != NULL
|
||||
+ && lookup_attribute ("hot", DECL_ATTRIBUTES (edge->callee->decl))
|
||||
+ != NULL))
|
||||
hints |= INLINE_HINT_known_hot;
|
||||
|
||||
gcc_checking_assert (size >= 0);
|
||||
diff --git a/gcc/testsuite/gcc.dg/ipa/inlinehint-6.c b/gcc/testsuite/gcc.dg/ipa/inlinehint-6.c
|
||||
new file mode 100644
|
||||
index 00000000000..1f3be641c6d
|
||||
--- /dev/null
|
||||
+++ b/gcc/testsuite/gcc.dg/ipa/inlinehint-6.c
|
||||
@@ -0,0 +1,47 @@
|
||||
+/* { dg-options "-O3 -c -fdump-ipa-inline-details -fno-early-inlining -fno-ipa-cp" } */
|
||||
+/* { dg-add-options bind_pic_locally } */
|
||||
+
|
||||
+#define size_t long long int
|
||||
+
|
||||
+struct A
|
||||
+{
|
||||
+ size_t f1, f2, f3, f4;
|
||||
+};
|
||||
+struct C
|
||||
+{
|
||||
+ struct A a;
|
||||
+ size_t b;
|
||||
+};
|
||||
+struct C x;
|
||||
+
|
||||
+__attribute__((hot)) struct C callee (struct A *a, struct C *c)
|
||||
+{
|
||||
+ c->a=(*a);
|
||||
+
|
||||
+ if((c->b + 7) & 17)
|
||||
+ {
|
||||
+ c->a.f1 = c->a.f2 + c->a.f1;
|
||||
+ c->a.f2 = c->a.f3 - c->a.f2;
|
||||
+ c->a.f3 = c->a.f2 + c->a.f3;
|
||||
+ c->a.f4 = c->a.f2 - c->a.f4;
|
||||
+ c->b = c->a.f2;
|
||||
+
|
||||
+ }
|
||||
+ return *c;
|
||||
+}
|
||||
+
|
||||
+__attribute__((hot)) struct C caller (size_t d, size_t e, size_t f, size_t g, struct C *c)
|
||||
+{
|
||||
+ struct A a;
|
||||
+ a.f1 = 1 + d;
|
||||
+ a.f2 = e;
|
||||
+ a.f3 = 12 + f;
|
||||
+ a.f4 = 68 + g;
|
||||
+ if (c->b > 0)
|
||||
+ return callee (&a, c);
|
||||
+ else
|
||||
+ return *c;
|
||||
+}
|
||||
+
|
||||
+/* { dg-final { scan-ipa-dump "known_hot" "inline" } } */
|
||||
+
|
||||
--
|
||||
2.18.2
|
||||
|
||||
@ -84,7 +84,7 @@
|
||||
Summary: Various compilers (C, C++, Objective-C, ...)
|
||||
Name: %{?scl_prefix}gcc
|
||||
Version: 12.2.1
|
||||
Release: 7
|
||||
Release: 8
|
||||
# libgcc, libgfortran, libgomp, libstdc++ and crtstuff have
|
||||
# GCC Runtime Exception.
|
||||
License: GPLv3+ and GPLv3+ with exceptions and GPLv2+ with exceptions and LGPLv2+ and BSD
|
||||
@ -135,6 +135,7 @@ Provides: %{?scl_prefix}gcc(major) = %{gcc_major}
|
||||
Patch0: 0001-change-gcc-version.patch
|
||||
Patch1: 0002-i386-Add-syscall-to-enable-AMX-for-latest-kernels.patch
|
||||
Patch2: 0003-Remove-AVX512_VP2INTERSECT-from-PTA_SAPPHIRERAPIDS.patch
|
||||
Patch3: 0004-Add-attribute-hot-judgement-for-INLINE_HINT_known_ho.patch
|
||||
|
||||
|
||||
# On ARM EABI systems, we do want -gnueabi to be part of the
|
||||
@ -595,6 +596,7 @@ not stable, so plugins must be rebuilt any time GCC is updated.
|
||||
%patch0 -p1
|
||||
%patch1 -p1
|
||||
%patch2 -p1
|
||||
%patch3 -p1
|
||||
|
||||
echo 'openEuler %{version}-%{release}' > gcc/DEV-PHASE
|
||||
|
||||
@ -2651,6 +2653,9 @@ end
|
||||
%doc rpm.doc/changelogs/libcc1/ChangeLog*
|
||||
|
||||
%changelog
|
||||
* Wed Nov 09 2022 Cui Lili <lili.cui@intel.com> 12.2.1-8
|
||||
- Add attribute hot judgement for INLINE_HINT_known_hot hint
|
||||
|
||||
* Wed Nov 09 2022 Cui Lili <lili.cui@intel.com> 12.2.1-7
|
||||
- Remove AVX512_VP2INTERSECT from PTA_SAPPHIRERAPIDS
|
||||
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user