Fix __wcsncmp_evex and __wcsncmp_avx2 [BZ #28755]
(cherry picked from commit 4035b008a59eb8f5b2701940f4fe8a1969c0fed9)
This commit is contained in:
parent
8153f2ed83
commit
ebae52d773
@ -66,7 +66,7 @@
|
|||||||
##############################################################################
|
##############################################################################
|
||||||
Name: glibc
|
Name: glibc
|
||||||
Version: 2.34
|
Version: 2.34
|
||||||
Release: 47
|
Release: 48
|
||||||
Summary: The GNU libc libraries
|
Summary: The GNU libc libraries
|
||||||
License: %{all_license}
|
License: %{all_license}
|
||||||
URL: http://www.gnu.org/software/glibc/
|
URL: http://www.gnu.org/software/glibc/
|
||||||
@ -174,6 +174,8 @@ Patch86: Linux-Detect-user-namespace-support-in-io-tst-getcwd.patch
|
|||||||
Patch87: Disable-debuginfod-in-printer-tests-BZ-28757.patch
|
Patch87: Disable-debuginfod-in-printer-tests-BZ-28757.patch
|
||||||
Patch88: i386-Remove-broken-CAN_USE_REGISTER_ASM_EBP-bug-2877.patch
|
Patch88: i386-Remove-broken-CAN_USE_REGISTER_ASM_EBP-bug-2877.patch
|
||||||
Patch89: x86-use-default-cache-size-if-it-cannot-be-determine.patch
|
Patch89: x86-use-default-cache-size-if-it-cannot-be-determine.patch
|
||||||
|
Patch90: x86-Fix-__wcsncmp_avx2-in-strcmp-avx2.S-BZ-28755.patch
|
||||||
|
Patch91: x86-Fix-__wcsncmp_evex-in-strcmp-evex.S-BZ-28755.patch
|
||||||
|
|
||||||
Patch9000: turn-default-value-of-x86_rep_stosb_threshold_form_2K_to_1M.patch
|
Patch9000: turn-default-value-of-x86_rep_stosb_threshold_form_2K_to_1M.patch
|
||||||
Patch9001: delete-no-hard-link-to-avoid-all_language-package-to.patch
|
Patch9001: delete-no-hard-link-to-avoid-all_language-package-to.patch
|
||||||
@ -1377,6 +1379,10 @@ fi
|
|||||||
%endif
|
%endif
|
||||||
|
|
||||||
%changelog
|
%changelog
|
||||||
|
* Fri Jan 28 2022 Qingqing Li <liqingqing3@huawei.com> - 2.34-48
|
||||||
|
- Fix __wcsncmp_evex in strcmp-evex.S [BZ #28755]
|
||||||
|
- Fix __wcsncmp_avx2 in strcmp-avx2.S [BZ #28755]
|
||||||
|
|
||||||
* Tue Jan 25 2022 Chuang Fang <fangchuangchuang@huawei.com> - 2.34-47
|
* Tue Jan 25 2022 Chuang Fang <fangchuangchuang@huawei.com> - 2.34-47
|
||||||
- Disable debuginfod in printer tests [BZ #28757]
|
- Disable debuginfod in printer tests [BZ #28757]
|
||||||
- i386: Remove broken CAN_USE_REGISTER_ASM_EBP (bug 28771)
|
- i386: Remove broken CAN_USE_REGISTER_ASM_EBP (bug 28771)
|
||||||
|
|||||||
40
x86-Fix-__wcsncmp_avx2-in-strcmp-avx2.S-BZ-28755.patch
Normal file
40
x86-Fix-__wcsncmp_avx2-in-strcmp-avx2.S-BZ-28755.patch
Normal file
@ -0,0 +1,40 @@
|
|||||||
|
From ddf0992cf57a93200e0c782e2a94d0733a5a0b87 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Noah Goldstein <goldstein.w.n@gmail.com>
|
||||||
|
Date: Sun, 9 Jan 2022 16:02:21 -0600
|
||||||
|
Subject: [PATCH] x86: Fix __wcsncmp_avx2 in strcmp-avx2.S [BZ# 28755]
|
||||||
|
|
||||||
|
Fixes [BZ# 28755] for wcsncmp by redirecting length >= 2^56 to
|
||||||
|
__wcscmp_avx2. For x86_64 this covers the entire address range so any
|
||||||
|
length larger could not possibly be used to bound `s1` or `s2`.
|
||||||
|
|
||||||
|
test-strcmp, test-strncmp, test-wcscmp, and test-wcsncmp all pass.
|
||||||
|
|
||||||
|
Signed-off-by: Noah Goldstein <goldstein.w.n@gmail.com>
|
||||||
|
---
|
||||||
|
sysdeps/x86_64/multiarch/strcmp-avx2.S | 10 ++++++++++
|
||||||
|
1 file changed, 10 insertions(+)
|
||||||
|
|
||||||
|
diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S
|
||||||
|
index a45f9d2..9c73b58 100644
|
||||||
|
--- a/sysdeps/x86_64/multiarch/strcmp-avx2.S
|
||||||
|
+++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S
|
||||||
|
@@ -87,6 +87,16 @@ ENTRY (STRCMP)
|
||||||
|
je L(char0)
|
||||||
|
jb L(zero)
|
||||||
|
# ifdef USE_AS_WCSCMP
|
||||||
|
+# ifndef __ILP32__
|
||||||
|
+ movq %rdx, %rcx
|
||||||
|
+ /* Check if length could overflow when multiplied by
|
||||||
|
+ sizeof(wchar_t). Checking top 8 bits will cover all potential
|
||||||
|
+ overflow cases as well as redirect cases where its impossible to
|
||||||
|
+ length to bound a valid memory region. In these cases just use
|
||||||
|
+ 'wcscmp'. */
|
||||||
|
+ shrq $56, %rcx
|
||||||
|
+ jnz __wcscmp_avx2
|
||||||
|
+# endif
|
||||||
|
/* Convert units: from wide to byte char. */
|
||||||
|
shl $2, %RDX_LP
|
||||||
|
# endif
|
||||||
|
--
|
||||||
|
1.8.3.1
|
||||||
|
|
||||||
40
x86-Fix-__wcsncmp_evex-in-strcmp-evex.S-BZ-28755.patch
Normal file
40
x86-Fix-__wcsncmp_evex-in-strcmp-evex.S-BZ-28755.patch
Normal file
@ -0,0 +1,40 @@
|
|||||||
|
From 7e08db3359c86c94918feb33a1182cd0ff3bb10b Mon Sep 17 00:00:00 2001
|
||||||
|
From: Noah Goldstein <goldstein.w.n@gmail.com>
|
||||||
|
Date: Sun, 9 Jan 2022 16:02:28 -0600
|
||||||
|
Subject: [PATCH] x86: Fix __wcsncmp_evex in strcmp-evex.S [BZ# 28755]
|
||||||
|
|
||||||
|
Fixes [BZ# 28755] for wcsncmp by redirecting length >= 2^56 to
|
||||||
|
__wcscmp_evex. For x86_64 this covers the entire address range so any
|
||||||
|
length larger could not possibly be used to bound `s1` or `s2`.
|
||||||
|
|
||||||
|
test-strcmp, test-strncmp, test-wcscmp, and test-wcsncmp all pass.
|
||||||
|
|
||||||
|
Signed-off-by: Noah Goldstein <goldstein.w.n@gmail.com>
|
||||||
|
---
|
||||||
|
sysdeps/x86_64/multiarch/strcmp-evex.S | 10 ++++++++++
|
||||||
|
1 file changed, 10 insertions(+)
|
||||||
|
|
||||||
|
diff --git a/sysdeps/x86_64/multiarch/strcmp-evex.S b/sysdeps/x86_64/multiarch/strcmp-evex.S
|
||||||
|
index 1d971f3..0cd939d 100644
|
||||||
|
--- a/sysdeps/x86_64/multiarch/strcmp-evex.S
|
||||||
|
+++ b/sysdeps/x86_64/multiarch/strcmp-evex.S
|
||||||
|
@@ -104,6 +104,16 @@ ENTRY (STRCMP)
|
||||||
|
je L(char0)
|
||||||
|
jb L(zero)
|
||||||
|
# ifdef USE_AS_WCSCMP
|
||||||
|
+# ifndef __ILP32__
|
||||||
|
+ movq %rdx, %rcx
|
||||||
|
+ /* Check if length could overflow when multiplied by
|
||||||
|
+ sizeof(wchar_t). Checking top 8 bits will cover all potential
|
||||||
|
+ overflow cases as well as redirect cases where its impossible to
|
||||||
|
+ length to bound a valid memory region. In these cases just use
|
||||||
|
+ 'wcscmp'. */
|
||||||
|
+ shrq $56, %rcx
|
||||||
|
+ jnz __wcscmp_evex
|
||||||
|
+# endif
|
||||||
|
/* Convert units: from wide to byte char. */
|
||||||
|
shl $2, %RDX_LP
|
||||||
|
# endif
|
||||||
|
--
|
||||||
|
1.8.3.1
|
||||||
|
|
||||||
Loading…
x
Reference in New Issue
Block a user