kata-containers/runtime/patches/0083-kata-runtime-add-removeMountBlockDevices-for-contain.patch
Vanient 5280b56d80 kata:sync bugfix patches, runtime 0079-0096 agent 0021-0024
runtime:
0079-kata-runtime-fix-qemu-SCSIBus-info-not-saved-into-pe.patch
0080-kata-runtime-fix-the-block-device-not-removed-in-dev.patch
0081-kata-runtime-cut-too-long-message-in-grpc-log.patch
0082-kata-runtime-change-sandbox-state-to-unhealthy-when-.patch
0083-kata-runtime-add-removeMountBlockDevices-for-contain.patch
0084-kata-runtime-fix-validInterface-func-cause-crash-pro.patch
0085-kata-runtime-fix-kata-netmon-does-not-exit-when-cont.patch
0086-kata-runtime-add-checkCPUSet-before-create-container.patch
0087-kata-runtime-force-delete-the-sandbox-and-container.patch
0088-kata-runtime-check-sandbox-healthy-state-before-call.patch
0089-kata-add-support-for-update-iface.patch
0090-kata-set-sandbox-or-container-status-to-unhealthy.patch
0091-kata-runtime-add-sandbox-file-lock-while-call-GetSan.patch
0092-qemu-add-arm64-to-support-list-of-dimm.patch
0093-kata-runtime-add-timeout-for-grpcWaitProcessRequest.patch
0094-kata-runtime-fix-update-iface-clean-NIC-cause-route-.patch
0095-kata-runtime-fix-qemu-process-resource-resi.patch
0096-kata-containers-Move-from-query-cpus-to-query-cpus-f.patch

agent:
0021-kata-agent-fix-sync-clock-not-work-problem.patch
0022-kata-agent-delete-container-id-from-sandbox-struct.patch
0023-kata-agent-modify-log-level.patch
0024-kata-agent-fix-agent.debug_console-not-work-when-bui.patch

Signed-off-by: Vanient <xiadanni1@huawei.com>
(cherry picked from commit f2d936028666741658157472b8de9d02187c6d55)
2022-09-13 10:29:41 +08:00

60 lines
1.9 KiB
Diff

From 490879dfd4d886bda2127d94967039771ff14d15 Mon Sep 17 00:00:00 2001
From: yangfeiyu <yangfeiyu2@huawei.com>
Date: Thu, 10 Dec 2020 17:21:59 +0800
Subject: [PATCH] kata-runtime: add removeMountBlockDevices for container
reason: when create container with -v, the device is created
and stored in sandbox device manager, if create container failed
in next steps, the rollback operation will not deal with container
mount device(mount blockdevice)
Conflict: NA
Reference:https://gitee.com/src-openeuler/kata-containers
Signed-off-by: yangfeiyu <yangfeiyu2@huawei.com>
---
virtcontainers/container.go | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/virtcontainers/container.go b/virtcontainers/container.go
index e40e313..601860c 100644
--- a/virtcontainers/container.go
+++ b/virtcontainers/container.go
@@ -909,6 +909,11 @@ func (c *Container) rollbackFailingContainerCreation() {
if err := c.detachDevices(); err != nil {
c.Logger().WithError(err).Error("rollback failed detachDevices()")
}
+
+ if errs := c.removeMountBlockDevices(); len(errs) > 0 {
+ c.Logger().Error("rollback failed removeMountBlockDevices()")
+ }
+
if err := c.removeDrive(); err != nil {
c.Logger().WithError(err).Error("rollback failed removeDrive()")
}
@@ -1494,6 +1499,22 @@ func (c *Container) isDriveUsed() bool {
return !(c.state.Fstype == "")
}
+func (c *Container) removeMountBlockDevices() []error {
+ var result []error
+ for _, mount := range c.mounts {
+ if len(mount.BlockDeviceID) > 0 {
+ if err := c.sandbox.devManager.RemoveDevice(mount.BlockDeviceID); err != nil {
+ result = append(result, err)
+ c.Logger().WithFields(logrus.Fields{
+ "container": c.id,
+ "block-device": mount.BlockDeviceID,
+ }).WithError(err).Error("remove block device failed")
+ }
+ }
+ }
+ return result
+}
+
func (c *Container) removeDrive() (err error) {
if c.isDriveUsed() {
c.Logger().Info("unplugging block device")
--
2.23.0