fxies: code review feedback

perl-Class-Inspector.spec

@@ -1,6 +1,6 @@
 Name:           perl-Class-Inspector
 Version:        1.32
-Release:        6
+Release:        5
 Summary:        Get information about a class and its structure
 
 License:        GPL+ or Artistic
@@ -9,15 +9,14 @@ Source0:        https://cpan.metacpan.org/authors/id/P/PL/PLICEASE/Class-Inspect
 
 BuildArch:      noarch
 
-# build
+
 BuildRequires:  make perl-generators
-BuildRequires:  perl(ExtUtils::MakeMaker) perl(File::Spec) >= 0.80
-# Test
-BuildRequires:  perl(Test::More)
+BuildRequires:  perl(ExtUtils::MakeMaker) perl(File::Spec) >= 0.80 perl(Test::More)
 Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
 
 %{?perl_default_filter}
 
+
 %description
 Class::Inspector allows you to get information about a loaded class.
 Most or all of this information can be found in other ways, but they aren't
@@ -26,21 +25,22 @@ wizardry, or strange and unusual looking code. Class::Inspector attempts to
 provide an easier, more friendly interface to this information.
 
 
+%package_help
+
+
 %prep
-%setup -q -n Class-Inspector-%{version}
+%autosetup -q -n Class-Inspector-%{version} -p1
 
 
 %build
-# Remove OPTIMIZE=... from noarch packages (unneeded)
 %{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="%{optflags}"
-make %{?_smp_mflags}
+%make_build
 
 
 %install
 rm -rf %{buildroot}
 make pure_install DESTDIR=%{buildroot}
 find %{buildroot} -type f -name .packlist -exec rm -f {} ';'
-# Remove the next line from noarch packages (unneeded)
 find %{buildroot} -type f -name '*.bs' -a -size 0 -exec rm -f {} ';'
 find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null ';'
 %{_fixperms} %{buildroot}/*
@@ -52,14 +52,14 @@ make test
 
 %files
 %license LICENSE
-%doc Changes README
-# For noarch packages: vendorlib
 %{perl_vendorlib}/*
-# For arch-specific packages: vendorarch
-# %{perl_vendorarch}/*
-# %exclude %dir %{perl_vendorarch}/auto/
+
+
+%files help
+%doc Changes README
 %{_mandir}/man3/*.3*
 
+
 %changelog
-* Thu Nov 28 2019 Qianbiao.NG <Qianbiao.NG@turnbig.net> - 1.32-6
+* Thu Nov 28 2019 Qianbiao.NG <Qianbiao.NG@turnbig.net> - 1.32-5
 - Repackage for openEuler OS