6c5e9f07c4
- i386/cpuid: Move leaf 7 to correct group - i386/cpuid: Decrease cpuid_i when skipping CPUID leaf 1F - i386/cpu: Mask with XCR0/XSS mask for FEAT_XSAVE_XCR0_HI and FEAT_XSAVE_XSS_HI leafs - i386/cpu: Clear FEAT_XSAVE_XSS_LO/HI leafs when CPUID_EXT_XSAVE is not available - target/i386: Change wrong XFRM value in SGX CPUID leaf - target/i386: Enable support for XSAVES based features - target/i386: Add kvm_get_one_msr helper - hw/block/hd-geometry: Do not override specified bios-chs-trans mainline inclusion commit fd8a68ad6823d33bedeba20a22857867a1c3890e category: bugfix - linux-user/riscv: Align signal frame to 16 bytes mainline inclusion commit 1eaa63429a9944265c92efdb94c02fabb231f564 category: bugfix - ipmi:smbus: Add a check around a memcpy mainline inclusion commit 3fde641e7286f9b968bdb3b4b922c6465f2a9abc category: bugfix - tests/tcg/linux-test: Fix random hangs in test_socket mainline inclusion commit b9e6074fc5b429b1e956e9c60db7e284a91e0f3d category: bugfix - qemu-options.hx: Don't claim "-serial" has limit of 4 serial ports Before v2.12, the implementation of serial ports was limited to a value of MAX_SERIAL_PORTS = 4. We now dynamically allocate the data structures for serial ports, so this limit is no longer present, but the documentation for the -serial options still reads: - target/ppc: Modify the uncorrect value irq to n_IRQ - block-migration: Ensure we don't crash during migration cleanup - target/s390x: fix handling of zeroes in vfmin/vfmax mainline inclusion commit 13c59eb09bd6d1fbc13f08b708226421f14a232b category: bugfix - hw/virtio/virtio-iommu: Enforce power-of-two notify for both MAP and UNMAP mainline inclusion commit 0522be9a0c0094088ccef7aab352c57f483ca250 category: bugfix - configure: Add missing POSIX-required space mainline inclusion commit 35a7a6fc5624b1df828d82f2dfa74d0e4188b3b2 category: bugfix - vga: fix incorrect line height in 640x200x2 mode mainline inclusion commit 37e7b86766244b62a406747bb78e049390d0b528 category: bugfix - hw/ide/core: set ERR_STAT in unsupported command completion - linux-user/flatload.c: Fix setting of image_info::end_code mainline inclusion commit 734a659ad264ac080457167e845ffabbaaa66d0e category: bugfix - load_elf: fix iterator's type for elf file processing - hw/misc/mps2-scc: Free MPS2SCC::oscclk[] array on finalize() - hw/nvram/xlnx-efuse: Free XlnxEFuse::ro_bits[] array on finalize() - hw/nvram/xlnx-efuse-ctrl: Free XlnxVersalEFuseCtrl[] "pg0-lock" array - chardev/char.c: fix "abstract device type" error message - block/rbd: fix handling of holes in .bdrv_co_block_status - qga: treat get-guest-fsinfo as "best effort" mainline inclusion commit bbb0151cf2e82489120a15df5e2eb9653312b0ec category: bugfix - usb/hcd-xhci: check slotid in xhci_wakeup_endpoint() mainline inclusion commit 84218892f05515d20347fde4506e1944eb11cb25 category: bugfix - hw/display/bcm2835_fb: Fix framebuffer allocation address mainline inclusion commit 5865d99fe88d8c8fa437c18c6b63fb2a8165634f category: bugfix - block/parallels: Fix buffer-based write call mainline inclusion commit eba088f91d21d9e42a81bef847173da30c5da961 category: bugfix - vl: Improve error message for conflicting -incoming and -loadvm - hw/smbios: Fix OEM strings table option validation Signed-off-by: Jiabo Feng <fengjiabo1@huawei.com> (cherry picked from commit 5d1a5160936dce1757c09050d97d12f42642794b)
54 lines
2.1 KiB
Diff
54 lines
2.1 KiB
Diff
From 5a8be2987986a0191b9d8a7a1a59f491e657ebad Mon Sep 17 00:00:00 2001
|
|
From: tangbinzy <tangbin_yewu@cmss.chinamobile.com>
|
|
Date: Fri, 8 Mar 2024 04:12:58 +0000
|
|
Subject: [PATCH] hw/display/bcm2835_fb: Fix framebuffer allocation address
|
|
mainline inclusion commit 5865d99fe88d8c8fa437c18c6b63fb2a8165634f category:
|
|
bugfix
|
|
|
|
---------------------------------------------------------------
|
|
|
|
This patch fixes the dedicated framebuffer mailbox interface by
|
|
removing an unneeded offset. This means that we pick the framebuffer
|
|
address in the same way that we do if the guest code uses the buffer
|
|
allocate mechanism of the bcm2835_property interface (case
|
|
0x00040001: /* Allocate buffer */ in bcm2835_property.c).
|
|
|
|
The documentation of this mailbox interface doesn't say anything
|
|
about using parts of the request buffer address to affect the
|
|
chosen framebuffer address:
|
|
https://github.com/raspberrypi/firmware/wiki/Mailbox-framebuffer-interface
|
|
|
|
Some baremetal applications like the Screen01/Screen02 examples from
|
|
Baking Pi tutorial[1] didn't work before this patch.
|
|
|
|
[1] https://www.cl.cam.ac.uk/projects/raspberrypi/tutorials/os/screen01.html
|
|
|
|
Signed-off-by: Alan Jian <alanjian85@outlook.com>
|
|
Message-id: 20220725145838.8412-1-alanjian85@outlook.com
|
|
[PMM: tweaked commit message]
|
|
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
|
|
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
|
|
|
|
Signed-off-by: tangbinzy <tangbin_yewu@cmss.chinamobile.com>
|
|
---
|
|
hw/display/bcm2835_fb.c | 3 +--
|
|
1 file changed, 1 insertion(+), 2 deletions(-)
|
|
|
|
diff --git a/hw/display/bcm2835_fb.c b/hw/display/bcm2835_fb.c
|
|
index 2be77bdd3a..ac17c472a5 100644
|
|
--- a/hw/display/bcm2835_fb.c
|
|
+++ b/hw/display/bcm2835_fb.c
|
|
@@ -279,8 +279,7 @@ static void bcm2835_fb_mbox_push(BCM2835FBState *s, uint32_t value)
|
|
newconf.xoffset = ldl_le_phys(&s->dma_as, value + 24);
|
|
newconf.yoffset = ldl_le_phys(&s->dma_as, value + 28);
|
|
|
|
- newconf.base = s->vcram_base | (value & 0xc0000000);
|
|
- newconf.base += BCM2835_FB_OFFSET;
|
|
+ newconf.base = s->vcram_base + BCM2835_FB_OFFSET;
|
|
|
|
/* Copy fields which we don't want to change from the existing config */
|
|
newconf.pixo = s->config.pixo;
|
|
--
|
|
2.27.0
|
|
|