6c5e9f07c4
- i386/cpuid: Move leaf 7 to correct group - i386/cpuid: Decrease cpuid_i when skipping CPUID leaf 1F - i386/cpu: Mask with XCR0/XSS mask for FEAT_XSAVE_XCR0_HI and FEAT_XSAVE_XSS_HI leafs - i386/cpu: Clear FEAT_XSAVE_XSS_LO/HI leafs when CPUID_EXT_XSAVE is not available - target/i386: Change wrong XFRM value in SGX CPUID leaf - target/i386: Enable support for XSAVES based features - target/i386: Add kvm_get_one_msr helper - hw/block/hd-geometry: Do not override specified bios-chs-trans mainline inclusion commit fd8a68ad6823d33bedeba20a22857867a1c3890e category: bugfix - linux-user/riscv: Align signal frame to 16 bytes mainline inclusion commit 1eaa63429a9944265c92efdb94c02fabb231f564 category: bugfix - ipmi:smbus: Add a check around a memcpy mainline inclusion commit 3fde641e7286f9b968bdb3b4b922c6465f2a9abc category: bugfix - tests/tcg/linux-test: Fix random hangs in test_socket mainline inclusion commit b9e6074fc5b429b1e956e9c60db7e284a91e0f3d category: bugfix - qemu-options.hx: Don't claim "-serial" has limit of 4 serial ports Before v2.12, the implementation of serial ports was limited to a value of MAX_SERIAL_PORTS = 4. We now dynamically allocate the data structures for serial ports, so this limit is no longer present, but the documentation for the -serial options still reads: - target/ppc: Modify the uncorrect value irq to n_IRQ - block-migration: Ensure we don't crash during migration cleanup - target/s390x: fix handling of zeroes in vfmin/vfmax mainline inclusion commit 13c59eb09bd6d1fbc13f08b708226421f14a232b category: bugfix - hw/virtio/virtio-iommu: Enforce power-of-two notify for both MAP and UNMAP mainline inclusion commit 0522be9a0c0094088ccef7aab352c57f483ca250 category: bugfix - configure: Add missing POSIX-required space mainline inclusion commit 35a7a6fc5624b1df828d82f2dfa74d0e4188b3b2 category: bugfix - vga: fix incorrect line height in 640x200x2 mode mainline inclusion commit 37e7b86766244b62a406747bb78e049390d0b528 category: bugfix - hw/ide/core: set ERR_STAT in unsupported command completion - linux-user/flatload.c: Fix setting of image_info::end_code mainline inclusion commit 734a659ad264ac080457167e845ffabbaaa66d0e category: bugfix - load_elf: fix iterator's type for elf file processing - hw/misc/mps2-scc: Free MPS2SCC::oscclk[] array on finalize() - hw/nvram/xlnx-efuse: Free XlnxEFuse::ro_bits[] array on finalize() - hw/nvram/xlnx-efuse-ctrl: Free XlnxVersalEFuseCtrl[] "pg0-lock" array - chardev/char.c: fix "abstract device type" error message - block/rbd: fix handling of holes in .bdrv_co_block_status - qga: treat get-guest-fsinfo as "best effort" mainline inclusion commit bbb0151cf2e82489120a15df5e2eb9653312b0ec category: bugfix - usb/hcd-xhci: check slotid in xhci_wakeup_endpoint() mainline inclusion commit 84218892f05515d20347fde4506e1944eb11cb25 category: bugfix - hw/display/bcm2835_fb: Fix framebuffer allocation address mainline inclusion commit 5865d99fe88d8c8fa437c18c6b63fb2a8165634f category: bugfix - block/parallels: Fix buffer-based write call mainline inclusion commit eba088f91d21d9e42a81bef847173da30c5da961 category: bugfix - vl: Improve error message for conflicting -incoming and -loadvm - hw/smbios: Fix OEM strings table option validation Signed-off-by: Jiabo Feng <fengjiabo1@huawei.com> (cherry picked from commit 5d1a5160936dce1757c09050d97d12f42642794b)
61 lines
2.1 KiB
Diff
61 lines
2.1 KiB
Diff
From c2fe51f5e42bbb95209318e8e766212fe832aa9b Mon Sep 17 00:00:00 2001
|
|
From: zhujun2 <zhujun2_yewu@cmss.chinamobile.com>
|
|
Date: Sun, 10 Mar 2024 20:15:39 -0700
|
|
Subject: [PATCH] hw/ide/core: set ERR_STAT in unsupported command completion
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
Currently, the first time sending an unsupported command
|
|
(e.g. READ LOG DMA EXT) will not have ERR_STAT set in the completion.
|
|
Sending the unsupported command again, will correctly have ERR_STAT set.
|
|
|
|
When ide_cmd_permitted() returns false, it calls ide_abort_command().
|
|
ide_abort_command() first calls ide_transfer_stop(), which will call
|
|
ide_transfer_halt() and ide_cmd_done(), after that ide_abort_command()
|
|
sets ERR_STAT in status.
|
|
|
|
ide_cmd_done() for AHCI will call ahci_write_fis_d2h() which writes the
|
|
current status in the FIS, and raises an IRQ. (The status here will not
|
|
have ERR_STAT set!).
|
|
|
|
Thus, we cannot call ide_transfer_stop() before setting ERR_STAT, as
|
|
ide_transfer_stop() will result in the FIS being written and an IRQ
|
|
being raised.
|
|
|
|
The reason why it works the second time, is that ERR_STAT will still
|
|
be set from the previous command, so when writing the FIS, the
|
|
completion will correctly have ERR_STAT set.
|
|
|
|
Set ERR_STAT before writing the FIS (calling cmd_done), so that we will
|
|
raise an error IRQ correctly when receiving an unsupported command.
|
|
|
|
Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
|
|
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
|
|
Message-id: 20230609140844.202795-3-nks@flawful.org
|
|
Signed-off-by: John Snow <jsnow@redhat.com>
|
|
(cherry picked from commit c3461c6264a7c8ca15b117e91fe5da786924a784)
|
|
Signed-off-by: zhujun2 <zhujun2_yewu@cmss.chinamobile.com>
|
|
---
|
|
hw/ide/core.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/hw/ide/core.c b/hw/ide/core.c
|
|
index 15138225be..0d925c5ca5 100644
|
|
--- a/hw/ide/core.c
|
|
+++ b/hw/ide/core.c
|
|
@@ -528,9 +528,9 @@ BlockAIOCB *ide_issue_trim(
|
|
|
|
void ide_abort_command(IDEState *s)
|
|
{
|
|
- ide_transfer_stop(s);
|
|
s->status = READY_STAT | ERR_STAT;
|
|
s->error = ABRT_ERR;
|
|
+ ide_transfer_stop(s);
|
|
}
|
|
|
|
static void ide_set_retry(IDEState *s)
|
|
--
|
|
2.27.0
|
|
|