From 0bb41ed82a5849b0c64d7046662825d84e983e4d Mon Sep 17 00:00:00 2001 From: Rose <83477269+AtariDreams@users.noreply.github.com> Date: Mon, 26 Jun 2023 15:08:51 -0400 Subject: [PATCH] Set command_info to NULL once it is freed The lack of setting to NULL is a holdover from when command_info was a local variable and not a global one. However, we given how other global variables are set to NULL, it is best that we do the same here to avoid potential issues should sudoers_policy_store_result be called again after the first time failed, otherwise we could get a double-free. --- plugins/sudoers/policy.c | 1 + 1 file changed, 1 insertion(+) diff --git a/plugins/sudoers/policy.c b/plugins/sudoers/policy.c index 7157fab2b..f018caca2 100644 --- a/plugins/sudoers/policy.c +++ b/plugins/sudoers/policy.c @@ -1054,6 +1054,7 @@ bad: while (info_len--) free(command_info[info_len]); free(command_info); + command_info = NULL; debug_return_bool(false); } -- 2.23.0