From 5379f5838df01fa22298a2b4f28270fd6b4cb871 Mon Sep 17 00:00:00 2001 From: Karel Zak Date: Mon, 6 Nov 2023 11:40:27 +0100 Subject: [PATCH] libmount: fix possible NULL dereference [coverity scan] Signed-off-by: Karel Zak --- libmount/src/tab.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libmount/src/tab.c b/libmount/src/tab.c index be0c13a..a19a5ae 100644 --- a/libmount/src/tab.c +++ b/libmount/src/tab.c @@ -659,7 +659,7 @@ int mnt_table_next_child_fs(struct libmnt_table *tb, struct libmnt_iter *itr, { struct libmnt_fs *fs; int parent_id, lastchld_id = 0, chld_id = 0; - int direction = mnt_iter_get_direction(itr); + int direction; if (!tb || !itr || !parent || !is_mountinfo(tb)) return -EINVAL; @@ -668,6 +668,7 @@ int mnt_table_next_child_fs(struct libmnt_table *tb, struct libmnt_iter *itr, mnt_fs_get_target(parent))); parent_id = mnt_fs_get_id(parent); + direction = mnt_iter_get_direction(itr); /* get ID of the previously returned child */ if (itr->head && itr->p != itr->head) { -- 2.33.0