91051566b9
Add check for realloc function to ignore this coredump and exit with error output Signed-off-by: swf504 <suweifeng1@huawei.com>
38 lines
1.2 KiB
Diff
38 lines
1.2 KiB
Diff
From f927695b86c3de29e930d0b920154a6ba294421f Mon Sep 17 00:00:00 2001
|
|
From: Weifeng Su <suweifeng1@huawei.com>
|
|
Date: Sun, 25 Jun 2023 02:55:45 +0000
|
|
Subject: libxcmd:add return value check for dynamic memory function
|
|
|
|
The result check was missed and It cause the coredump like:
|
|
0x00005589f3e358dd in add_command (ci=0x5589f3e3f020 <health_cmd>) at command.c:37
|
|
0x00005589f3e337d8 in init_commands () at init.c:37
|
|
init (argc=<optimized out>, argv=0x7ffecfb0cd28) at init.c:102
|
|
0x00005589f3e33399 in main (argc=<optimized out>, argv=<optimized out>) at init.c:112
|
|
|
|
Add check for realloc function to ignore this coredump and exit with
|
|
error output
|
|
|
|
Signed-off-by: Weifeng Su <suweifeng1@huawei.com>
|
|
---
|
|
libxcmd/command.c | 4 ++++
|
|
1 file changed, 4 insertions(+)
|
|
|
|
diff --git a/libxcmd/command.c b/libxcmd/command.c
|
|
index a76d151..e260309 100644
|
|
--- a/libxcmd/command.c
|
|
+++ b/libxcmd/command.c
|
|
@@ -34,6 +34,10 @@ add_command(
|
|
const cmdinfo_t *ci)
|
|
{
|
|
cmdtab = realloc((void *)cmdtab, ++ncmds * sizeof(*cmdtab));
|
|
+ if (!cmdtab) {
|
|
+ perror(_("adding libxcmd command"));
|
|
+ exit(1);
|
|
+ }
|
|
cmdtab[ncmds - 1] = *ci;
|
|
qsort(cmdtab, ncmds, sizeof(*cmdtab), compare);
|
|
}
|
|
--
|
|
2.33.0
|
|
|